Use the current working directory's config file. #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading the configuration using a relative path from core/, load it from the current working directory. This means that a Bedrock command should be called necessarily from a project root directory (where the config is supposed to live), but I guess this was already the case when using commands defined in the Gulpfile or in the package.json file. In other words, this change shouldn't have an impact on existing installs, but paves the road to allow calling Bedrock from projects that don't have the full source code of Bedrock within their own directory, and provide their own configuration files. See usebedrock#320 for details.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/monocompany/bedrock/GtoPM7oDfnt1RhxoPiyJpcQK5Qc7 |
|
Happy to merge and happy to see some external activity on Bedrock, very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the configuration using a relative path from
core/, load it from the current working directory.
This means that a Bedrock command should be called necessarily from a
project root directory (where the config is supposed to live), but I
guess this was already the case when using commands defined in the
Gulpfile or in the package.json file.
In other words, this change shouldn't have an impact on existing
installs, but paves the road to allow calling Bedrock from projects that
don't have the full source code of Bedrock within their own directory,
and provide their own configuration files.
See #320 for details.